Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tag and configurator rules to keep up with official site #2330

Merged
merged 27 commits into from
Nov 2, 2023
Merged

Improve tag and configurator rules to keep up with official site #2330

merged 27 commits into from
Nov 2, 2023

Conversation

chickenlj
Copy link
Contributor

@chickenlj chickenlj commented Jun 7, 2023 •
edited
Loading

related to #2260

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

FoghostCn and others added 15 commits July 7, 2023 16:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2023 •
edited
Loading

Codecov Report

Merging #2330 (3d97d4c) into main (3d97d4c) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d97d4c differs from pull request most recent head 9498a4f. Consider uploading reports for the commit 9498a4f to get more accurate results

@@           Coverage Diff           @@
##             main    #2330   +/-   ##
=======================================
  Coverage   45.83%   45.83%           
=======================================
  Files         270      270           
  Lines       18649    18649           
=======================================
  Hits         8547     8547           
  Misses       9209     9209           
  Partials      893      893

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Lvnszn
Copy link
Contributor

Lvnszn commented Aug 9, 2023

可以加一个相关的ut么

Lvnszn
Lvnszn approved these changes Aug 9, 2023
View reviewed changes
config/router_config.go Show resolved Hide resolved
config_center/configurator/override.go Show resolved Hide resolved
registry/base_configuration_listener.go Show resolved Hide resolved
justxuewei
justxuewei reviewed Aug 13, 2023
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chickenlj! A few comments here:

common/match.go Outdated Show resolved Hide resolved
common/match.go Outdated Show resolved Hide resolved
common/match.go Outdated Show resolved Hide resolved
common/constant/cluster.go Outdated Show resolved Hide resolved
config_center/configurator/override.go Outdated Show resolved Hide resolved
config_center/parser/configuration_parser.go Show resolved Hide resolved
config_center/parser/configuration_parser.go Show resolved Hide resolved
config_center/parser/configuration_parser.go Show resolved Hide resolved
cluster/router/tag/match.go Outdated Show resolved Hide resolved
justxuewei
justxuewei reviewed Aug 13, 2023
View reviewed changes
common/match.go Outdated Show resolved Hide resolved
@chickenlj
Copy link
Contributor Author 

2023-08-16T07:32:33.749Z	INFO	store/cache_manager.go:195	The cacheFile [test_meta_cache] was cleared
--- FAIL: TestMetaInfoCacheManager (4.00s)
    cache_manager_test.go:143: unexpected number of items in cache: got 0, want 1
    cache_manager_test.go:147: failed to get key4: <nil>
FAIL
coverage: 92.3% of statements
FAIL	dubbo.apache.org/dubbo-go/v3/registry/servicediscovery/store	8.005s

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chickenlj chickenlj merged commit 410e2f8 into apache:main Nov 2, 2023
6 checks passed
@chickenlj chickenlj deleted the router-enhance branch November 2, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justxuewei justxuewei justxuewei left review comments

@jasondeng1997 jasondeng1997 jasondeng1997 approved these changes

@Lvnszn Lvnszn Lvnszn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chickenlj @codecov-commenter @Lvnszn @justxuewei @jasondeng1997 @FoghostCn @FinalT