Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use promauto and promhttp #2333

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

ev1lQuark
Copy link
Contributor

This is a draft PR for #2332

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ev1lQuark ev1lQuark marked this pull request as ready for review June 10, 2023 02:21
@codecov-commenter
Copy link

Codecov Report

Merging #2333 (f748432) into main (b998087) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

❗ Current head f748432 differs from pull request most recent head ed05537. Consider uploading reports for the commit ed05537 to get more accurate results

@@            Coverage Diff             @@
##             main    #2333      +/-   ##
==========================================
- Coverage   44.24%   44.11%   -0.14%     
==========================================
  Files         294      294              
  Lines       17860    17890      +30     
==========================================
- Hits         7902     7892      -10     
- Misses       9117     9158      +41     
+ Partials      841      840       -1     
Impacted Files Coverage Δ
metrics/prometheus/common.go 29.59% <62.16%> (-17.95%) ⬇️
metrics/prometheus/metric_set.go 100.00% <100.00%> (ø)
metrics/prometheus/reporter.go 66.66% <100.00%> (+22.22%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 95b463b into apache:main Jun 10, 2023
@ev1lQuark ev1lQuark deleted the refactor branch June 10, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants