Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add switch for metric collector #2424

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

FoghostCn
Copy link
Contributor

@FoghostCn FoghostCn commented Sep 13, 2023

add switch for metric collector, include metadata、registry、config-center、rpc

split PrometheusRegistry.Export method into two method to avoid large method body

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2424 (5ac057d) into main (5ac057d) will not change coverage.
The diff coverage is n/a.

❗ Current head 5ac057d differs from pull request most recent head 22c06ca. Consider uploading reports for the commit 22c06ca to get more accurate results

@@           Coverage Diff           @@
##             main    #2424   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         269      269           
  Lines       18220    18220           
=======================================
  Hits         8233     8233           
  Misses       9110     9110           
  Partials      877      877           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ev1lQuark ev1lQuark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 40dd198 into apache:main Oct 24, 2023
6 checks passed
@FoghostCn FoghostCn deleted the switch branch April 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants