Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1] fix: metadata port reuse #2548

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[3.1] fix: metadata port reuse #2548

merged 2 commits into from
Dec 28, 2023

Conversation

FinalT
Copy link
Member

@FinalT FinalT commented Dec 27, 2023 •
edited by baerwang
Loading

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d204c4e) 44.91% compared to head (e5a7f69) 44.85%.

❗ Current head e5a7f69 differs from pull request most recent head c869b5e. Consider uploading reports for the commit c869b5e to get more accurate results

Files Patch % Lines
metadata/service/exporter/configurable/exporter.go 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.1    #2548      +/-   ##
===============================================
- Coverage        44.91%   44.85%   -0.06%     
===============================================
  Files              270      270              
  Lines            18354    18366      +12     
===============================================
- Hits              8243     8238       -5     
- Misses            9225     9242      +17     
  Partials           886      886

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chickenlj
chickenlj approved these changes Dec 27, 2023
View reviewed changes
metadata/service/exporter/configurable/exporter.go Outdated
if ok {
port = protocolConfig.Port
} else {
logger.Warnf("[Metadata Service] Dubbo-go %s version's MetadataService does not support triple protocol,"+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning message would better be "[Metadata Service] Dubbo-go %s version's MetadataService only support dubbo protocol, ". Because it might be other protocols beyond dubbo and triple.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's better

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chickenlj
Copy link
Contributor

@FoghostCn PTAL.

chickenlj
chickenlj approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@baerwang baerwang mentioned this pull request Dec 28, 2023
Closed
@baerwang baerwang changed the title fix：metadata port reuse fix: metadata port reuse Dec 28, 2023
@baerwang baerwang merged commit 796f908 into apache:release-3.1 Dec 28, 2023
5 checks passed
@FinalT FinalT deleted the fix-metadata-port branch December 29, 2023 08:41
@justxuewei justxuewei changed the title fix: metadata port reuse [3.1] fix: metadata port reuse Jan 5, 2024
@FinalT FinalT mentioned this pull request Jan 7, 2024
Closed
chickenlj pushed a commit that referenced this pull request Jan 14, 2024
@FinalT
Merge bug-fix in 3.1 into main branch(#2553,#2548,#2551) (#2571)
4f11dba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FinalT @codecov-commenter @chickenlj @baerwang