Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: After disconnection with ZK registry, cosumer can't listen to provider changes #258

Merged
merged 8 commits into from
Dec 4, 2019

Conversation

pantianying
Copy link
Member

@pantianying pantianying commented Nov 22, 2019

What this PR does:
fix #259 (comment)
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #258 into develop will decrease coverage by 1.11%.
The diff coverage is 11.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.38%   65.26%   -1.12%     
===========================================
  Files          111      111              
  Lines         7038     7053      +15     
===========================================
- Hits          4672     4603      -69     
- Misses        1907     1993      +86     
+ Partials       459      457       -2
Impacted Files Coverage Δ
registry/zookeeper/registry.go 55.79% <0%> (-2.99%) ⬇️
registry/zookeeper/listener.go 62.5% <100%> (+0.79%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 54.71% <0%> (-16.99%) ⬇️
protocol/dubbo/pool.go 57.86% <0%> (-15.74%) ⬇️
protocol/dubbo/listener.go 51.19% <0%> (-10.72%) ⬇️
protocol/dubbo/codec.go 76.47% <0%> (-5.89%) ⬇️
config_center/apollo/impl.go 84.41% <0%> (-2.6%) ⬇️
protocol/dubbo/readwriter.go 67.9% <0%> (-2.47%) ⬇️
remoting/zookeeper/listener.go 46.9% <0%> (-1.04%) ⬇️
registry/etcdv3/registry.go 50.5% <0%> (-1.02%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4014c59...ec0209d. Read the comment docs.

registry/zookeeper/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks changed the title add code to fix bug Fix: [#259](https://github.com/apache/dubbo-go/issues/259) Nov 23, 2019
@vongosling
Copy link
Member

@pantianying Do not use the topic style like "Fix: #259 #", Could you detail your fixing problem, getting more people to see what you're doing from the name and more people involved

@pantianying pantianying changed the title Fix: [#259](https://github.com/apache/dubbo-go/issues/259) Fix: After disconnection with ZK registry, cosumer can't listen to provider changes Nov 26, 2019
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit 21d8262 into apache:develop Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants