Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BUG: The SIGSYS and SIGSTOP are not supported in windows platform #262

Merged
merged 2 commits into from
Nov 24, 2019

Conversation

flycash
Copy link
Member

@flycash flycash commented Nov 24, 2019

What this PR does:
The SIGSYS and SIGSTOP are not supported in the Windows platform, so we should define the signals we catch on different platforms.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #262 into develop will decrease coverage by 0.78%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #262      +/-   ##
===========================================
- Coverage    66.33%   65.54%   -0.79%     
===========================================
  Files          111      111              
  Lines         7042     7038       -4     
===========================================
- Hits          4671     4613      -58     
- Misses        1912     1969      +57     
+ Partials       459      456       -3
Impacted Files Coverage Δ
config/graceful_shutdown.go 58.62% <12.5%> (-0.72%) ⬇️
protocol/dubbo/pool.go 57.86% <0%> (-15.74%) ⬇️
protocol/dubbo/listener.go 51.19% <0%> (-10.72%) ⬇️
protocol/dubbo/codec.go 76.47% <0%> (-5.89%) ⬇️
config_center/apollo/impl.go 84.41% <0%> (-2.6%) ⬇️
protocol/dubbo/readwriter.go 67.9% <0%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71552be...921b524. Read the comment docs.

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 162826f into apache:develop Nov 24, 2019
@flycash flycash deleted the bug/SinalInWindows branch January 12, 2020 11:59
@kimmking
Copy link
Member

To be fixing bug should create a related issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants