Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: add async call for dubbo protocol #272

Merged
merged 14 commits into from
Dec 19, 2019

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Dec 4, 2019

What this PR does:
Ftr: add async call for dubbo protocol

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #272 into develop will decrease coverage by 0.83%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
- Coverage    66.38%   65.54%   -0.84%     
===========================================
  Files          111      111              
  Lines         7038     7076      +38     
===========================================
- Hits          4672     4638      -34     
- Misses        1907     1982      +75     
+ Partials       459      456       -3
Impacted Files Coverage Δ
common/rpc_service.go 88.54% <ø> (ø) ⬆️
common/proxy/proxy.go 97.75% <0%> (-2.25%) ⬇️
config/reference_config.go 81.72% <100%> (+0.82%) ⬆️
protocol/dubbo/client.go 69.07% <100%> (ø) ⬆️
protocol/dubbo/dubbo_invoker.go 92.3% <100%> (+8.21%) ⬆️
protocol/dubbo/codec.go 76.47% <100%> (-5.89%) ⬇️
common/proxy/proxy_factory/default.go 20.96% <100%> (+2.63%) ⬆️
config/service.go 92.3% <80%> (-7.7%) ⬇️
protocol/dubbo/pool.go 57.86% <0%> (-15.74%) ⬇️
protocol/dubbo/listener.go 51.19% <0%> (-10.72%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4014c59...25d2c23. Read the comment docs.

@pantianying
Copy link
Member

can you provide a use case on https://github.com/dubbogo/dubbogo-samples

@zouyx
Copy link
Member Author

zouyx commented Dec 6, 2019

ok,i have a case but haven't commit

@zouyx
Copy link
Member Author

zouyx commented Dec 6, 2019

BTW,Is there any problem with this pr?

Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyx
Copy link
Member Author

zouyx commented Dec 11, 2019

@pantianying added samples

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks
Copy link
Contributor

LGTM

@fangyincheng fangyincheng merged commit 9c83f5e into apache:develop Dec 19, 2019
@zouyx zouyx deleted the feature/addAsyncCall branch December 26, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants