Ftr: Develop req timeout config #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this pr add request timeout for each remote method? |
hxmhlt
reviewed
Dec 19, 2019
pantianying
changed the title
pantianying
changed the title
# Conflicts: # config/method_config.go # config/reference_config.go
Codecov Report
@@ Coverage Diff @@
## develop #284 +/- ##
===========================================
- Coverage 66.58% 65.77% -0.81%
===========================================
Files 112 113 +1
Lines 7182 7255 +73
===========================================
- Hits 4782 4772 -10
- Misses 1934 2008 +74
- Partials 466 475 +9
Continue to review full report at Codecov.
|
yes |
pantianying
changed the title
|
LGTM |
flycash
approved these changes
Jan 8, 2020
|
LGTM |
fangyincheng
reviewed
Jan 8, 2020
protocol/dubbo/dubbo_protocol.go
Outdated
| //default requestTimeout | ||
| var requestTimeout = config.GetConsumerConfig().RequestTimeout | ||
|
|
||
| requestTimeoutStr := url.GetParam(constant.REQUEST_TIMEOUT, config.GetConsumerConfig().Request_Timeout) |
There was a problem hiding this comment.
when is REQUEST_TIMEOUT set to url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: