Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr : nacos config #357

Merged
merged 15 commits into from
Feb 13, 2020
Merged

Ftr : nacos config #357

merged 15 commits into from
Feb 13, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Feb 10, 2020

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@3fd3cf8). Click here to learn what that means.
The diff coverage is 72.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #357   +/-   ##
==========================================
  Coverage           ?   66.74%           
==========================================
  Files              ?      150           
  Lines              ?     7935           
  Branches           ?        0           
==========================================
  Hits               ?     5296           
  Misses             ?     2137           
  Partials           ?      502
Impacted Files Coverage Δ
config_center/configurator/mock.go 0% <ø> (ø)
config_center/nacos/factory.go 12.5% <ø> (ø)
remoting/etcdv3/listener.go 46.08% <ø> (ø)
common/extension/config_center.go 0% <ø> (ø)
cluster/directory/static_directory.go 90.47% <ø> (ø)
protocol/protocolwrapper/mock_protocol_filter.go 0% <ø> (ø)
cluster/cluster_impl/failfast_cluster.go 100% <ø> (ø)
cluster/loadbalance/random.go 100% <ø> (ø)
cluster/cluster_impl/registry_aware_cluster.go 100% <ø> (ø)
protocol/jsonrpc/json.go 52.94% <ø> (ø)
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd3cf8...f0a4d8f. Read the comment docs.

@AlexStocks
Copy link
Contributor

zouyx, u'd better add some remark for those open funcs.

@zouyx
Copy link
Member Author

zouyx commented Feb 11, 2020

i will fix it today , fixed test case yesterday

config_center/nacos/client.go Show resolved Hide resolved
config_center/nacos/client.go Show resolved Hide resolved
config_center/nacos/factory.go Show resolved Hide resolved
config_center/nacos/impl.go Outdated Show resolved Hide resolved
config_center/nacos/listener.go Outdated Show resolved Hide resolved
Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks
Copy link
Contributor

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config_center/nacos/client_test.go Outdated Show resolved Hide resolved
config_center/nacos/client_test.go Outdated Show resolved Hide resolved
@flycash flycash merged commit d0d3ac1 into apache:develop Feb 13, 2020
@zouyx zouyx deleted the feature/nacos branch February 13, 2020 14:18
@zouyx zouyx mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants