Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Grpc tracing for client and server #397

Merged
merged 11 commits into from
Mar 13, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Mar 11, 2020

What this PR does:

Verify this feature with jaeger, result as below.

image

I will provide sample tomorrow

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #397 into develop will decrease coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #397      +/-   ##
===========================================
- Coverage    67.35%   67.12%   -0.23%     
===========================================
  Files          161      161              
  Lines         8331     8340       +9     
===========================================
- Hits          5611     5598      -13     
- Misses        2198     2218      +20     
- Partials       522      524       +2
Impacted Files Coverage Δ
protocol/grpc/server.go 68.42% <100%> (+1.75%) ⬆️
protocol/grpc/client.go 89.47% <100%> (+1.97%) ⬆️
protocol/dubbo/listener.go 57.52% <0%> (-5.38%) ⬇️
protocol/dubbo/codec.go 72.5% <0%> (-5%) ⬇️
protocol/dubbo/pool.go 76.71% <0%> (-4.57%) ⬇️
common/proxy/proxy.go 93.06% <0%> (-2.81%) ⬇️
protocol/dubbo/readwriter.go 68.29% <0%> (-2.44%) ⬇️
config/generic_service.go 0% <0%> (ø) ⬆️
protocol/dubbo/client.go 69.09% <0%> (+1.21%) ⬆️
config_center/nacos/facade.go 73.52% <0%> (+8.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab850a4...be26d41. Read the comment docs.

@zouyx zouyx changed the title Add: Grpc tracing for client and server [WIP] Add: Grpc tracing for client and server Mar 12, 2020
@zouyx zouyx changed the title [WIP] Add: Grpc tracing for client and server Add: Grpc tracing for client and server Mar 12, 2020
@zouyx
Copy link
Member Author

zouyx commented Mar 12, 2020

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

protocol/grpc/client.go Outdated Show resolved Hide resolved
protocol/grpc/server.go Outdated Show resolved Hide resolved
Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit 12699c5 into apache:develop Mar 13, 2020
@zouyx zouyx deleted the feature/grpctracing branch March 17, 2020 03:14
@zouyx
Copy link
Member Author

zouyx commented Mar 17, 2020

#321

@flycash flycash linked an issue Mar 31, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Context与Tracing
6 participants