Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user can add attachment #398

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

pantianying
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #398 into develop will decrease coverage by 0.05%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #398      +/-   ##
==========================================
- Coverage    67.36%   67.3%   -0.06%     
==========================================
  Files          161     161              
  Lines         8331    8335       +4     
==========================================
- Hits          5612    5610       -2     
- Misses        2196    2202       +6     
  Partials       523     523
Impacted Files Coverage Δ
config/generic_service.go 0% <ø> (ø) ⬆️
common/proxy/proxy.go 93.06% <25%> (-2.81%) ⬇️
config_center/nacos/facade.go 64.7% <0%> (-8.83%) ⬇️
filter/filter_impl/hystrix_filter.go 68.64% <0%> (-3.39%) ⬇️
protocol/dubbo/client.go 69.09% <0%> (+1.21%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 80.64% <0%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31ac1d...d99e9b3. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pantianying pantianying merged commit 068f7ba into apache:develop Mar 12, 2020
@pantianying pantianying mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants