Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align 2.7.5: Event dispatch service discovery #487

Merged

Conversation

Patrick0308
Copy link
Contributor

What this PR does:
Align 2.7.5: Implement of Event dispatch service discovery. It will be used in Service Discovery Registry.
Which issue(s) this PR fixes:
This close #450

@codecov-io
Copy link

codecov-io commented Apr 21, 2020

Codecov Report

Merging #487 into feature/dubbo-2.7.5 will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feature/dubbo-2.7.5     #487      +/-   ##
=======================================================
- Coverage                66.81%   66.66%   -0.15%     
=======================================================
  Files                      196      199       +3     
  Lines                    10125    10212      +87     
=======================================================
+ Hits                      6765     6808      +43     
- Misses                    2708     2751      +43     
- Partials                   652      653       +1     
Impacted Files Coverage Δ
common/observer/event.go 16.66% <0.00%> (ø)
...istry/common/event_publishing_service_discovery.go 40.00% <40.00%> (ø)
registry/common/service_discovery_event.go 66.66% <66.66%> (ø)
registry/common/service_instance_event.go 71.42% <71.42%> (ø)
protocol/dubbo/client.go 67.87% <0.00%> (-1.22%) ⬇️
remoting/kubernetes/watch.go 78.30% <0.00%> (-0.95%) ⬇️
remoting/kubernetes/listener.go 56.07% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a558d8...9f7e1f3. Read the comment docs.

@flycash flycash self-requested a review April 21, 2020 13:34
@Patrick0308 Patrick0308 changed the title (WIP) Align 2.7.5: Event dispatch service discovery Align 2.7.5: Event dispatch service discovery May 8, 2020
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyx zouyx merged commit c958389 into apache:feature/dubbo-2.7.5 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants