Opt: opt err handling #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
May 22, 2020
AlexStocks
approved these changes
May 22, 2020
Codecov Report
@@ Coverage Diff @@
## develop #536 +/- ##
===========================================
- Coverage 66.55% 66.32% -0.24%
===========================================
Files 184 184
Lines 9729 9712 -17
===========================================
- Hits 6475 6441 -34
- Misses 2613 2629 +16
- Partials 641 642 +1
Continue to review full report at Codecov.
|
zouyx
approved these changes
May 24, 2020
AlexStocks
approved these changes
May 25, 2020
Patrick0308
approved these changes
May 25, 2020
Comment on lines
+185
to
+189
| err = staticDir.BuildRouterChain(invokers) | ||
| if err != nil { | ||
| logger.Error(err) | ||
| continue | ||
| } |
There was a problem hiding this comment.
I like this
Suggested change
| err = staticDir.BuildRouterChain(invokers) | |
| if err != nil { | |
| logger.Error(err) | |
| continue | |
| } | |
| if err = staticDir.BuildRouterChain(invokers); err != nil { | |
| logger.Error(err) | |
| continue | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
optimize error handling
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: