Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: update the comments in metrics #547

Merged

Conversation

williamfeng323
Copy link
Contributor

What this PR does:
Mod: Updated the comments in metrics, corrected the grammar.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #547 into develop will decrease coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #547      +/-   ##
===========================================
- Coverage    67.20%   66.51%   -0.70%     
===========================================
  Files          174      184      +10     
  Lines         9261     9712     +451     
===========================================
+ Hits          6224     6460     +236     
- Misses        2432     2611     +179     
- Partials       605      641      +36     
Impacted Files Coverage Δ
metrics/prometheus/reporter.go 100.00% <100.00%> (ø)
registry/zookeeper/registry.go 46.15% <0.00%> (-9.30%) ⬇️
protocol/dubbo/listener.go 57.52% <0.00%> (-5.38%) ⬇️
common/url.go 65.83% <0.00%> (-5.33%) ⬇️
config_center/nacos/impl.go 71.08% <0.00%> (-4.31%) ⬇️
config_center/apollo/impl.go 82.71% <0.00%> (-4.30%) ⬇️
remoting/zookeeper/facade.go 70.27% <0.00%> (-4.02%) ⬇️
config/provider_config.go 55.88% <0.00%> (-3.50%) ⬇️
filter/filter_impl/hystrix_filter.go 68.64% <0.00%> (-3.39%) ⬇️
registry/nacos/registry.go 58.42% <0.00%> (-3.37%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3c02c...3cd5fab. Read the comment docs.

@zouyx zouyx linked an issue May 31, 2020 that may be closed by this pull request
@zouyx zouyx self-requested a review May 31, 2020 14:57
metrics/reporter.go Outdated Show resolved Hide resolved
@williamfeng323 williamfeng323 force-pushed the feature/metrics-comment-optimise branch from 8f6f8f3 to 5453ab9 Compare May 31, 2020 17:36
@williamfeng323 williamfeng323 force-pushed the feature/metrics-comment-optimise branch from 5453ab9 to 3cd5fab Compare May 31, 2020 17:37
@AlexStocks AlexStocks requested a review from flycash June 1, 2020 02:07
@zouyx zouyx merged commit 4af26b9 into apache:develop Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for metrics directory
5 participants