Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: using different labels btw provider and consumer, k8s service discovery across namespaces #577

Merged
merged 23 commits into from
Jun 5, 2020

Conversation

sxllwx
Copy link
Member

@sxllwx sxllwx commented Jun 1, 2020

What this PR does:

  1. Add multi namespace support for kubernetes registry
  2. Switch from using List & Watch directly to using informer

Which issue(s) this PR fixes:

Fixes #512 #458

Special notes for your reviewer:

Working In Progress, DONOT merge.

Does this PR introduce a user-facing change?:


@sxllwx sxllwx changed the base branch from master to develop June 1, 2020 06:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #577 into develop will increase coverage by 0.25%.
The diff coverage is 58.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #577      +/-   ##
===========================================
+ Coverage    66.43%   66.68%   +0.25%     
===========================================
  Files          184      185       +1     
  Lines         9712     9749      +37     
===========================================
+ Hits          6452     6501      +49     
+ Misses        2620     2611       -9     
+ Partials       640      637       -3     
Impacted Files Coverage Δ
remoting/kubernetes/listener.go 52.83% <ø> (-3.25%) ⬇️
registry/kubernetes/registry.go 57.69% <50.00%> (-13.47%) ⬇️
remoting/kubernetes/registry_controller.go 55.67% <55.67%> (ø)
remoting/kubernetes/client.go 76.25% <69.69%> (+17.88%) ⬆️
remoting/kubernetes/watch.go 78.89% <76.92%> (+0.59%) ⬆️
registry/kubernetes/listener.go 72.34% <100.00%> (ø)
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0.00%> (-2.16%) ⬇️
protocol/dubbo/client.go 67.87% <0.00%> (-1.22%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af26b9...0f9a717. Read the comment docs.

@sxllwx sxllwx changed the title (WIP) kubernetes as registry enhance kubernetes as registry enhance Jun 3, 2020
@sxllwx sxllwx requested a review from hxmhlt June 3, 2020 14:49
@sxllwx
Copy link
Member Author

sxllwx commented Jun 3, 2020

/assgin @hxmhlt

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit 106040d into apache:develop Jun 5, 2020
@AlexStocks AlexStocks changed the title kubernetes as registry enhance Ftr: using different labels btw provider and consumer, k8s service discovery across namespaces Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imp: k8s service discovery across namespaces, using different labels btw provider and consumer
6 participants