Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mosn logo #603

Merged
merged 1 commit into from
Jun 12, 2020
Merged

add mosn logo #603

merged 1 commit into from
Jun 12, 2020

Conversation

cch123
Copy link
Contributor

@cch123 cch123 commented Jun 12, 2020

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@cch123
Copy link
Contributor Author

cch123 commented Jun 12, 2020

改成 html 的表格了,这样整齐一些

</td>
<td align="center" valign="middle">
<a href="https://github.com/mosn" target="_blank">
<img width="222px" src="https://raw.githubusercontent.com/mosn/community/master/icons/png/mosn-labeled-horizontal.png">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里真用 MOSN 社区的图片链接啊,不怕图片更换位置吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他们都是外链。。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里先加外链吧,等后面我们这边统一收到resource里面。

@codecov-commenter
Copy link

Codecov Report

Merging #603 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
- Coverage   67.20%   66.89%   -0.32%     
==========================================
  Files         174      174              
  Lines        9261     9261              
==========================================
- Hits         6224     6195      -29     
- Misses       2432     2458      +26     
- Partials      605      608       +3     
Impacted Files Coverage Δ
protocol/dubbo/listener.go 57.52% <0.00%> (-5.38%) ⬇️
protocol/dubbo/codec.go 72.50% <0.00%> (-5.00%) ⬇️
protocol/dubbo/pool.go 76.71% <0.00%> (-4.57%) ⬇️
filter/filter_impl/hystrix_filter.go 68.64% <0.00%> (-3.39%) ⬇️
protocol/dubbo/readwriter.go 68.29% <0.00%> (-2.44%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0.00%> (-2.16%) ⬇️
remoting/kubernetes/watch.go 78.30% <0.00%> (-0.95%) ⬇️
protocol/dubbo/client.go 69.09% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3c02c...4fe4180. Read the comment docs.

@hxmhlt hxmhlt merged commit d955400 into apache:master Jun 12, 2020
zouyx pushed a commit to zouyx/dubbo-go that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants