Ftr: consul service discovery #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoxinge
reviewed
Aug 8, 2020
|
@gaoxinge thanks, I've solved these problems |
fangyincheng
reviewed
Aug 8, 2020
zouyx
reviewed
Aug 9, 2020
gaoxinge
reviewed
Aug 9, 2020
code clean
gaoxinge
reviewed
Aug 10, 2020
AlexStocks
reviewed
Aug 12, 2020
AlexStocks
reviewed
Aug 12, 2020
registry/service_discovery.go
Outdated
| * Initializes the ServiceDiscovery | ||
| * | ||
| */ | ||
| Initialize(registryURL common.URL) error |
There was a problem hiding this comment.
u add this func for EventPublishingServiceDiscovery. and then u add it to ServiceDiscovery interface. Pls think again.
what's more, the func name is so long which should be Init.
beiwei30
reviewed
Sep 8, 2020
beiwei30
reviewed
Sep 8, 2020
beiwei30
reviewed
Sep 9, 2020
beiwei30
reviewed
Sep 9, 2020
beiwei30
reviewed
Sep 9, 2020
zouyx
reviewed
Sep 9, 2020
zouyx
approved these changes
Sep 10, 2020
gaoxinge
approved these changes
Sep 12, 2020
AlexStocks
reviewed
Sep 12, 2020
added 2 commits
September 12, 2020 15:27
AlexStocks
reviewed
Sep 12, 2020
AlexStocks
reviewed
Sep 12, 2020
AlexStocks
reviewed
Sep 12, 2020
AlexStocks
reviewed
Sep 13, 2020
AlexStocks
approved these changes
Sep 13, 2020
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 22, 2020
Ftr: consul service discovery
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
Ftr: consul service discovery
kzhan
pushed a commit
to kzhan/dubbo-go
that referenced
this pull request
Jun 5, 2021
Ftr: consul service discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
implement consul discovery
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: