Ftr: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{} #713
Conversation
… invocation and result
… invocation and result
… invocation and result
先等另外一个pr review通过之后，我修改下依赖，来跑CI。 因为两个pr有依赖。 |
ok，thanks a lot |
| require ( | ||
| github.com/apache/dubbo-go-hessian2 v1.6.0-rc1.0.20200819060303-9b32032784f6 | ||
| ) | ||
|
|
There was a problem hiding this comment.
这个是为了跑通集成测试，等hessian发布最新版本之后，可以删除。
zouyx
changed the title
|
@joeyzhouy zhou 帮忙协调下review。 |
这个暂时不要动吧。 面向应用开发者还是不动先，面向框架扩展的得升级。 |
common/proxy/proxy_test.go
Outdated
| @@ -19,6 +19,8 @@ package proxy | |||
|
|
|||
| import ( | |||
| "context" | |||
| hessian "github.com/apache/dubbo-go-hessian2" | |||
There was a problem hiding this comment.
OMG. move it to the second import block, pls.
protocol/dubbo/dubbo_invoker.go
Outdated
| @@ -19,14 +19,14 @@ package dubbo | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/opentracing/opentracing-go" | |||
There was a problem hiding this comment.
move this into github.com imports.
protocol/invocation.go
Outdated
| Attachments() map[string]string | ||
| // AttachmentsByKey gets attachment by key , if nil then return default value | ||
| Attachments() map[string]interface{} | ||
| // AttachmentsByKey gets attachment by key , if nil then return default value. （It will be discarded） |
There was a problem hiding this comment.
change it to 'deprecated in the future'?
| @@ -151,6 +151,10 @@ func (p *Proxy) Implement(v common.RPCService) { | |||
| for k, value := range m { | |||
| inv.SetAttachments(k, value) | |||
| } | |||
| } else if m2, ok2 := atm.(map[string]interface{}); ok2 { | |||
There was a problem hiding this comment.
we'd better leave some comments here so that others can understand the context better.
There was a problem hiding this comment.
IMO, the comment should be aligned with the else branch in the same line or under the else branch if it is too long.
cvictory
force-pushed
the
attachent_to_object
branch
from
d0286be
to
f7440be
Compare
| @@ -151,6 +151,10 @@ func (p *Proxy) Implement(v common.RPCService) { | |||
| for k, value := range m { | |||
| inv.SetAttachments(k, value) | |||
| } | |||
| } else if m2, ok2 := atm.(map[string]interface{}); ok2 { | |||
There was a problem hiding this comment.
IMO, the comment should be aligned with the else branch in the same line or under the else branch if it is too long.
|
|
||
| package dubbo | ||
|
|
||
| import ( |
There was a problem hiding this comment.
pls do not place dubbo-go package and other packages in the same import block.
protocol/dubbo/hessian2/const.go
Outdated
| ErrIllegalPackage = perrors.New("illegal package!") | ||
| ) | ||
|
|
||
| // DescRegex ... |
There was a problem hiding this comment.
pls add comment. If u do not wanna add comment, use "// nolint" instead.
| PackageType_BitSize = 0x2f | ||
| ) | ||
|
|
||
| // PackageType ... |
There was a problem hiding this comment.
pls add comment. If u do not wanna add comment, use "// nolint" instead.
…ap[string]interface{} (apache#713)
* support attachment from map[sting]string to map[string]interface{} in invocation and result
# Conflicts:
# cluster/router/tag/tag_router.go
…ap[string]interface{} (#713)
* support attachment from map[sting]string to map[string]interface{} in invocation and result
# Conflicts:
# cluster/router/tag/tag_router.go
…ap[string]interface{} (apache#713)
* support attachment from map[sting]string to map[string]interface{} in invocation and result
1.attachment类型从attachment type from map[string]stiring 到 map[string]interface{} ，和dubbo java对齐
2.功能分成两部分，一部分会在dubbo-go里提交，一部分需要修改hessian.
dubbo-go-hessian :apache/dubbo-go-hessian2#218
这个pr依赖dubbo-go-hessian merge完成之后，修改依赖的版本之后，才能通过CI。提交上来是为了方便review的时候一起看。
先忽略CI