Fix: #734 #735
Merged
Fix: #734 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zouyx
approved these changes
Sep 4, 2020
AlexStocks
reviewed
Sep 4, 2020
| @@ -322,7 +322,7 @@ func (l *ZkEventListener) listenDirEvent(conf *common.URL, zkPath string, listen | |||
| for { | |||
| select { | |||
| case <-ticker.C: | |||
| l.handleZkNodeEvent(zkEvent.Path, children, listener) | |||
| l.handleZkNodeEvent(zkPath, children, listener) | |||
There was a problem hiding this comment.
pls add the issue as the comment here
AlexStocks
approved these changes
Sep 4, 2020
Patrick0308
approved these changes
Sep 6, 2020
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 22, 2020
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
Malvin666
pushed a commit
to Malvin666/dubbo-go
that referenced
this pull request
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
try to fix #734
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: