Imp: Improve map access concurrency #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should change target branch to |
zouyx
reviewed
Sep 8, 2020
watermelo
approved these changes
Sep 8, 2020
AlexStocks
approved these changes
Sep 8, 2020
skyao
commented
Sep 8, 2020
There was a problem hiding this comment.
The standard operation to access similar map:
- get with key, in most case it will return the stored one, make it AS FAST AS POSIBLE
- special case, if the key is not set, we should do initial and store it to map. We will do this only once, if no concurreny.
- More Special case, there are several thread access this NOT stored key, and all of them found the key is not set and should do initial and store, so we need to use LoadOrStore to avoid override the saved value.
zouyx
approved these changes
Sep 9, 2020
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 22, 2020
Imp: Improve map access concurrency
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
Imp: Improve map access concurrency
kzhan
pushed a commit
to kzhan/dubbo-go
that referenced
this pull request
Jun 5, 2021
Imp: Improve map access concurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR is to improve the accessing of map in concurrency environment.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: