Fix: consul destory #788
Merged
Fix: consul destory #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Oct 12, 2020
registry/consul/registry.go
Outdated
| select { | ||
| case <-done: | ||
| logger.Infof("consulRegistry unregister done") | ||
| case <-ticker.C: |
There was a problem hiding this comment.
a time.After is enough in this simple case.
There was a problem hiding this comment.
Yes, I fixed it.
Codecov Report
@@ Coverage Diff @@
## develop #788 +/- ##
===========================================
- Coverage 63.75% 59.87% -3.88%
===========================================
Files 239 259 +20
Lines 12796 12753 -43
===========================================
- Hits 8158 7636 -522
- Misses 3849 4163 +314
- Partials 789 954 +165
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Oct 13, 2020
|
LGTM |
zouyx
pushed a commit
to zouyx/dubbo-go
that referenced
this pull request
Oct 31, 2020
Fix: consul destory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
修复consul Registry 在interrupt后不会立刻从注册中心消失的bug
Which issue(s) this PR fixes:
Fixes #749
Special notes for your reviewer:
修复consul Registry 在interrupt后不会立刻从注册中心消失的bug，在consulRegistry的Destory函数中增加对Unregister函数的调用。从而从consul反注册。增加超时unregister超时的处理。
Does this PR introduce a user-facing change?:
NONE