Ftr: Add dubbo-go-cli telnet tool support #818

LaurenceLiZhixin · 2020-10-29T06:00:32Z

What this PR does:
增加了dubbo-go的cli命令行工具，可以方便用户直连特定服务，发送包含特定参数的rpc请求，并展现结果。

Which issue(s) this PR fixes:

Special notes for your reviewer:
支持嵌套struct，目前只支持单个参数的请求包和回包。
数据类型由于需要在json中定义，只支持golang基本数据类型：string、整形、浮点。

Does this PR introduce a user-facing change?:
NONE

codecov-io · 2020-10-31T02:23:29Z

Codecov Report

Merging #818 (18ab1c4) into 1.5 (17c4a9e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.5     #818      +/-   ##
==========================================
+ Coverage   59.45%   59.46%   +0.01%     
==========================================
  Files         261      261              
  Lines       12950    12973      +23     
==========================================
+ Hits         7700     7715      +15     
- Misses       4276     4282       +6     
- Partials      974      976       +2

Impacted Files	Coverage Δ
cluster/cluster_impl/failback_cluster_invoker.go	`73.49% <0.00%> (-2.41%)`	⬇️
...rotocol/protocolwrapper/protocol_filter_wrapper.go	`48.14% <0.00%> (-1.86%)`	⬇️
remoting/getty/listener.go	`39.79% <0.00%> (-1.30%)`	⬇️
remoting/getty/getty_client.go	`44.08% <0.00%> (-0.22%)`	⬇️
common/url.go	`60.89% <0.00%> (ø)`
remoting/kubernetes/listener.go	`50.52% <0.00%> (ø)`
remoting/kubernetes/watch.go	`79.12% <0.00%> (+2.19%)`	⬆️
remoting/kubernetes/client.go	`75.00% <0.00%> (+2.94%)`	⬆️
cluster/cluster_impl/base_cluster_invoker.go	`61.11% <0.00%> (+8.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c4a9e...18ab1c4. Read the comment docs.

AlexStocks · 2020-11-03T05:10:18Z

tools/cli/README.md

@@ -0,0 +1,18 @@
+# dubbo-go-cli
+
+### 1. 解决问题


hey, guy, pls using English in an Apache project. Or u rename this file to readme_cn.md and add an English readme.

AlexStocks · 2020-11-03T05:11:02Z

tools/cli/client/client.go

+ }, nil
+}
+
+func createTCPAddr(host string, port int) string {


pls using net.JoinHostPort instead.

AlexStocks · 2020-11-03T05:12:38Z

tools/cli/client/client.go

+ seqId := t.addPendingResponse(userPkg)
+ defer t.removePendingResponse(seqId)
+
+ requestDataChannel := make(chan []byte)


do not need to set its length for this chan?

AlexStocks · 2020-11-03T05:12:54Z

tools/cli/client/client.go

+
+ requestDataChannel := make(chan []byte)
+ doneChannel := make(chan bool)
+ responseDataChannel := make(chan []byte)


the same as above

AlexStocks · 2020-11-03T05:13:34Z

tools/cli/common/protocol.go

+)
+
+var (
+ protocols = make(map[string]func() protocol.Protocol)


pls set its init length param, such as 8

AlexStocks · 2020-11-03T05:14:21Z

tools/cli/example/README.md

@@ -0,0 +1,132 @@
+# dubbo-go-cli 使用示例


the same as above readme. pls rename this file to readme_cn.md and add an english readme.

LaurenceLiZhixin · 2020-11-26T08:57:43Z

Now waiting for pr: apache/dubbo-go-hessian2#243 to be merged.
Then I'll refer the latest hessian2 pkg and complete this pr.

LaurenceLiZhixin · 2020-11-27T10:09:18Z

I fix the change of hessian pkg, and problems above. Now I think it's able to merge.
Reviewer can try example in Readme file, to check if it works as hoped.

AlexStocks · 2020-11-27T16:24:09Z

tools/cli/README.md

+
+### Third party dependence（temporary）
+
+github.com/LaurenceLiZhixin/dubbo-go-hessian2 \


why using ur branch?

AlexStocks · 2020-11-27T16:24:30Z

tools/cli/README.md

+### Third party dependence（temporary）
+
+github.com/LaurenceLiZhixin/dubbo-go-hessian2 \
+github.com/LaurenceLiZhixin/json-interface-parser 


pls submit ur code to github.com/dubbogo/gost.

AlexStocks · 2021-01-25T05:00:26Z

have u finished ur work? if so, pls fix the github action failure.

LaurenceLiZhixin · 2021-01-27T09:35:19Z

I have finished my work.

have u finished ur work? if so, pls fix the github action failure.

tools/cli/client/client.go

Ftr: Add dubbo-go-cli telnet tool support

LaurenceLiZhixin added 8 commits October 26, 2020 16:58

ftr: add cli tool

3b9229b

fix: add readme

16baeda

fix: change go import

63ae531

fix: fix import block

b99152a

fix: add lisence

4f2d462

chore: add all license

6d5a472

fix: change comment to English

841c4e6

chore: retry cicd

0008fa9

zouyx added the enhancement New feature or request label Nov 3, 2020

zouyx added this to the v1.5.5 milestone Nov 3, 2020

zouyx requested review from AlexStocks, fangyincheng, hxmhlt and watermelo November 3, 2020 03:01

AlexStocks reviewed Nov 3, 2020

View reviewed changes

LaurenceLiZhixin added 5 commits November 7, 2020 12:10

fix: add enEnglish readme, add timeout param

4fe1da9

fix: change hessian register method

54d4984

fix: use vv.Type to check POJO

7b7b8a5

chore

34e0999

chore: comment fix

8f7fc94

Fix: change hessian pkg

62ec58a

zouyx removed this from the v1.5.5 milestone Nov 27, 2020

AlexStocks reviewed Nov 27, 2020

View reviewed changes

李志信 added 4 commits December 4, 2020 08:49

fix

b41de25

fix: change rely repository to dubbogo/gost

aebfe94

fix: fix merge conflict

11fd33b

fix: change hessian2 version to 1.8.0

1599fd4

AlexStocks force-pushed the develop branch 3 times, most recently from d12bf6a to e633a73 Compare January 9, 2021 09:35

LaurenceLiZhixin added 4 commits January 10, 2021 10:35

Merge remote-tracking branch 'upstream/develop' into develop

d305b67

fix: fix conflict

93168df

Fix: go fmt

34289f4

fix: go mod tidy

1ab564f

AlexStocks force-pushed the develop branch 2 times, most recently from 603f989 to 794ab77 Compare January 10, 2021 13:12

LaurenceLiZhixin added 3 commits January 13, 2021 09:32

Merge remote-tracking branch 'upstream/develop' into develop

5919b11

Merge remote-tracking branch 'upstream/develop' into develop

3dc2f17

Merge remote-tracking branch 'upstream/develop' into develop

55737aa

AlexStocks force-pushed the develop branch 2 times, most recently from 25c3b98 to 9a666eb Compare January 23, 2021 11:12

AlexStocks added this to the v1.5.6 milestone Jan 23, 2021

LaurenceLiZhixin added 2 commits January 26, 2021 13:36

Merge remote-tracking branch 'upstream/develop' into develop

65cd856

Merge branch 'develop' into feature/cli-support

f3ef409

cityiron changed the base branch from develop to 1.5 January 26, 2021 13:55

LaurenceLiZhixin changed the base branch from 1.5 to develop January 27, 2021 03:04

LaurenceLiZhixin changed the base branch from develop to 1.5 January 27, 2021 03:05

cityiron approved these changes Feb 2, 2021

View reviewed changes

AlexStocks reviewed Feb 2, 2021

View reviewed changes

tools/cli/client/client.go Show resolved Hide resolved

fix: add comment

18ab1c4

AlexStocks approved these changes Feb 2, 2021

View reviewed changes

watermelo approved these changes Feb 3, 2021

View reviewed changes

cityiron merged commit 3ae865a into apache:1.5 Feb 3, 2021

AlexStocks pushed a commit that referenced this pull request Apr 14, 2021

Merge pull request #818 from LaurenceLiZhixin/feature/cli-support

49daddf

Ftr: Add dubbo-go-cli telnet tool support

justxuewei mentioned this pull request Jul 2, 2021

Doc: Update README #1294

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ftr: Add dubbo-go-cli telnet tool support #818

Ftr: Add dubbo-go-cli telnet tool support #818

LaurenceLiZhixin commented Oct 29, 2020 •

edited

Loading

codecov-io commented Oct 31, 2020 •

edited

Loading

AlexStocks Nov 3, 2020

AlexStocks Nov 3, 2020

AlexStocks Nov 3, 2020

AlexStocks Nov 3, 2020

AlexStocks Nov 3, 2020

AlexStocks Nov 3, 2020

LaurenceLiZhixin commented Nov 26, 2020

LaurenceLiZhixin commented Nov 27, 2020

AlexStocks Nov 27, 2020

AlexStocks Nov 27, 2020

AlexStocks commented Jan 25, 2021

LaurenceLiZhixin commented Jan 27, 2021


		### Third party dependence（temporary）

		github.com/LaurenceLiZhixin/dubbo-go-hessian2 \

Ftr: Add dubbo-go-cli telnet tool support #818

Ftr: Add dubbo-go-cli telnet tool support #818

Conversation

LaurenceLiZhixin commented Oct 29, 2020 • edited Loading

codecov-io commented Oct 31, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LaurenceLiZhixin commented Nov 26, 2020

LaurenceLiZhixin commented Nov 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexStocks commented Jan 25, 2021

LaurenceLiZhixin commented Jan 27, 2021

LaurenceLiZhixin commented Oct 29, 2020 •

edited

Loading

codecov-io commented Oct 31, 2020 •

edited

Loading