-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: refact heartbeat #889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangyincheng
changed the title
Fix: heartbeat for server->client
[WIP] Fix: heartbeat for server->client
Nov 23, 2020
AlexStocks
reviewed
Nov 24, 2020
Codecov Report
@@ Coverage Diff @@
## develop #889 +/- ##
===========================================
- Coverage 60.15% 59.85% -0.31%
===========================================
Files 260 260
Lines 12783 12840 +57
===========================================
- Hits 7690 7685 -5
- Misses 4133 4192 +59
- Partials 960 963 +3
Continue to review full report at Codecov.
|
fangyincheng
changed the title
[WIP] Fix: heartbeat for server->client
[WIP] Fix: refact heartbeat
Nov 25, 2020
hxmhlt
approved these changes
Nov 27, 2020
zouyx
approved these changes
Nov 29, 2020
AlexStocks
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now: close session when once timeout
doing: close session when three times timeout(60s*3)
now: print error when error response
doing: close session when three times timeout(60s*3)