Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] file service discovery path can run in windows #932

Merged
merged 4 commits into from
Jan 10, 2021

Conversation

cityiron
Copy link
Contributor

What this PR does:
Windows run fail because the path is "/" and the filename contains "." or ":" ..., I use filePath replace path, replace some special character.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Dec 12, 2020

Codecov Report

Merging #932 (cc7fb2e) into develop (1f708d7) will decrease coverage by 0.07%.
The diff coverage is 48.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #932      +/-   ##
===========================================
- Coverage    59.95%   59.87%   -0.08%     
===========================================
  Files          260      261       +1     
  Lines        12855    12937      +82     
===========================================
+ Hits          7707     7746      +39     
- Misses        4188     4233      +45     
+ Partials       960      958       -2     
Impacted Files Coverage Δ
config_center/file/impl.go 50.40% <47.05%> (-2.07%) ⬇️
registry/file/service_discovery.go 45.74% <100.00%> (ø)
metadata/definition/mock.go 0.00% <0.00%> (-25.00%) ⬇️
config/config_loader.go 40.95% <0.00%> (-12.77%) ⬇️
config/service_config.go 55.03% <0.00%> (-7.65%) ⬇️
cluster/router/chain/chain.go 69.04% <0.00%> (-1.59%) ⬇️
remoting/getty/pool.go 68.72% <0.00%> (-0.89%) ⬇️
registry/protocol/protocol.go 76.96% <0.00%> (-0.88%) ⬇️
common/proxy/proxy.go 88.46% <0.00%> (-0.86%) ⬇️
registry/nacos/service_discovery.go 64.13% <0.00%> (-0.45%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f708d7...cc7fb2e. Read the comment docs.

@zouyx zouyx added this to the v1.5.5 milestone Dec 13, 2020
@zouyx zouyx added the bug Something isn't working label Dec 13, 2020
config_center/file/impl.go Outdated Show resolved Hide resolved
config_center/file/impl.go Outdated Show resolved Hide resolved
config_center/file/impl.go Outdated Show resolved Hide resolved
@zouyx zouyx removed this from the v1.5.5 milestone Dec 13, 2020
@cityiron
Copy link
Contributor Author

张训 help test in windows successful.

@zouyx zouyx added this to the v1.5.6 milestone Dec 18, 2020
@AlexStocks AlexStocks force-pushed the develop branch 9 times, most recently from 3e08d41 to 6a1c4a3 Compare January 3, 2021 10:27
@AlexStocks AlexStocks force-pushed the develop branch 15 times, most recently from 9ef971c to f11f1f9 Compare January 4, 2021 14:53
@AlexStocks AlexStocks force-pushed the develop branch 6 times, most recently from d12bf6a to e633a73 Compare January 9, 2021 09:35
@AlexStocks AlexStocks merged commit f1ccb34 into apache:develop Jan 10, 2021
AlexStocks added a commit that referenced this pull request Jan 10, 2021
[Fix] file service discovery path can run in windows
AlexStocks added a commit that referenced this pull request Jan 10, 2021
[Fix] file service discovery path can run in windows
AlexStocks added a commit that referenced this pull request Jan 10, 2021
[Fix] file service discovery path can run in windows
AlexStocks added a commit that referenced this pull request Apr 14, 2021
[Fix] file service discovery path can run in windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants