-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hessian2 反序列化bug #3640 #8
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
============================================
+ Coverage 24.24% 24.46% +0.21%
- Complexity 455 460 +5
============================================
Files 89 89
Lines 6289 6302 +13
Branches 1048 1048
============================================
+ Hits 1525 1542 +17
+ Misses 4547 4545 -2
+ Partials 217 215 -2
Continue to review full report at Codecov.
|
Please see the java7 error https://travis-ci.org/dubbo/hessian-lite/jobs/506137514 |
I will look later, because I don't have a java7 environment yet, would you give me some advice? |
I think you can setup a java7 in your pc Additional, please add some test case to verify your change for the issue: apache/dubbo#3640 |
Yes,I will add test case later. |
I tested it in java7 in my local environment and found that it was passed. I don’t have any ideas for now. Let’s take another look. |
LGTM |
@@ -90,6 +90,7 @@ | |||
private static final int GAP = 16; | |||
private static Field _detailMessageField; | |||
private static boolean _isCloseStreamOnClose; | |||
public static boolean _isNull = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用静态全局变量,在多线程场景中是否会存在线程安全问题?
这逻辑根本不对,多线程的时候,直接报错。 |
修复apache/dubbo#3640 问题