Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hessian2 反序列化bug #3640 #8

Merged
merged 5 commits into from
Mar 19, 2019
Merged

fix hessian2 反序列化bug #3640 #8

merged 5 commits into from
Mar 19, 2019

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Mar 14, 2019

修复apache/dubbo#3640 问题

@CrazyHZM CrazyHZM closed this Mar 14, 2019
@CrazyHZM CrazyHZM reopened this Mar 14, 2019
@codecov-io
Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.21%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     24.24%   24.46%   +0.21%     
- Complexity      455      460       +5     
============================================
  Files            89       89              
  Lines          6289     6302      +13     
  Branches       1048     1048              
============================================
+ Hits           1525     1542      +17     
+ Misses         4547     4545       -2     
+ Partials        217      215       -2
Impacted Files Coverage Δ Complexity Δ
.../com/caucho/hessian/io/CollectionDeserializer.java 73.07% <100%> (+5.68%) 14 <3> (+2) ⬆️
...m/alibaba/com/caucho/hessian/io/Hessian2Input.java 19.69% <71.42%> (+0.65%) 64 <8> (+2) ⬆️
.../alibaba/com/caucho/hessian/io/Hessian2Output.java 24.43% <0%> (+0.51%) 33% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcfcf4...42ff241. Read the comment docs.

@lovepoem
Copy link
Member

Please see the java7 error https://travis-ci.org/dubbo/hessian-lite/jobs/506137514

@CrazyHZM
Copy link
Member Author

Please see the java7 error https://travis-ci.org/dubbo/hessian-lite/jobs/506137514

I will look later, because I don't have a java7 environment yet, would you give me some advice?

@lovepoem
Copy link
Member

I will look later, because I don't have a java7 environment yet, would you give me some advice?

I think you can setup a java7 in your pc

Additional, please add some test case to verify your change for the issue: apache/dubbo#3640

@CrazyHZM
Copy link
Member Author

I will look later, because I don't have a java7 environment yet, would you give me some advice?

I think you can setup a java7 in your pc

Additional, please add some test case to verify your change for the issue: apache/incubator-dubbo#3640

Yes,I will add test case later.

@CrazyHZM
Copy link
Member Author

I will look later, because I don't have a java7 environment yet, would you give me some advice?

I think you can setup a java7 in your pc

Additional, please add some test case to verify your change for the issue: apache/incubator-dubbo#3640

I tested it in java7 in my local environment and found that it was passed. I don’t have any ideas for now. Let’s take another look.

@lovepoem
Copy link
Member

LGTM

@lovepoem lovepoem merged commit 5a74492 into apache:master Mar 19, 2019
@@ -90,6 +90,7 @@
private static final int GAP = 16;
private static Field _detailMessageField;
private static boolean _isCloseStreamOnClose;
public static boolean _isNull = false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用静态全局变量,在多线程场景中是否会存在线程安全问题?

@fingthinking
Copy link

这逻辑根本不对,多线程的时候,直接报错。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants