feat: Improve RPC communication based on HTTP/2 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const transport = createDubboTransport({ | ||
| baseUrl: "http://localhost:8080", | ||
| httpVersion: "1.1", |
|
|
||
| ## <span id="accessService">访问服务</span> | ||
|
|
||
| 最简单方式是使用 HTTP/1.1 POST 请求访问服务，参数则作以标准 JSON 格式作为 HTTP 负载传递。如下是使用 cURL 命令的访问示例: |
|
这个是怎么自测的诶，有写单元测试吗 |
这个自测单元没写，example例子实现了一下 |
|
感觉单测还是有必要的吧，比如没带 serviceVersion 和 serviceGroup，或者只带了其中一个参数，或者请求失败场景啥的 |
OK，那我找个时间把这个单测整一下，我看看怎么去单测一下。 |
jianyi-gronk
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Consider whether you need to add multiple test cases, such as when serviceVersion is missing, serviceGroup is missing, or both are missing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #362
The initial version of the HTTP/2 code can be improved gradually.