-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement service discovery #103
Conversation
robberphex
commented
Jan 19, 2023
•
edited
Loading
edited
- Connect to a host:
- Or use customized directory:
f6ccea7
to
fc8be9f
Compare
a657e92
to
f66be94
Compare
@@ -189,3 +189,35 @@ impl Metadata { | |||
header | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation of RpcInvocation is too complicated. Now we can use a struct as metadata. In future, we can rebuild this struct by new requirements
dubbo/src/triple/client/triple.rs
Outdated
@@ -83,6 +92,14 @@ impl<T> TripleClient<T> { | |||
self.builder.unwrap(), | |||
) | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dubbo的一个特性是配置优先。我建议可以将服务发现相关的配置放到clientBuilder中,通过配置来启动服务发现;这样可以简化dubbo-build侧client生成的代码
另外,自定义配置directory应该是高级能力。
5611c1b
to
c27c66b
Compare
6d49aff
to
186c176
Compare
186c176
to
18d87ae
Compare
// pub fn build(builder: ClientBuilder) -> Self { | ||
// Self { | ||
// inner: TripleClient::new(builder), | ||
// } | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove