Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftr: add nacos registry #107

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Ftr: add nacos registry #107

merged 1 commit into from
Feb 15, 2023

Conversation

onewe
Copy link
Contributor

@onewe onewe commented Feb 10, 2023

relate #46

@yang20150702
Copy link
Member

Good Work. I suggest that you can add example about nacos registry in examples.

@onewe
Copy link
Contributor Author

onewe commented Feb 10, 2023

OK, I will add an example soon

@onewe
Copy link
Contributor Author

onewe commented Feb 13, 2023

By now, the dubbo server side can not add customizable registry. It need a mechanism which can dynamic load plugin , but it's so hard.

Doesn't use rust ffi implement it?

@robberphex
Copy link
Collaborator

Don't change extension mechanism at this PR, we could change extension mechanism in another PR.

@onewe
Copy link
Contributor Author

onewe commented Feb 15, 2023

Ok, I won't do that.

@yang20150702
Copy link
Member

LGTM

@yang20150702 yang20150702 merged commit 3609347 into apache:main Feb 15, 2023
@onewe onewe deleted the issues/46 branch February 16, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onewe @yang20150702 @robberphex