Supports grpc+json and the curl tool #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
将json消息转化为grpc消息，继而交给grpc handle进行处理，并以json格式返回数据
Optimized the logic of TripleServer and TripleClient, achieving code reuse. Merged encoding and encoding_json
dubbo/src/triple/server/triple.rs
Outdated
| pub struct TripleServer<T> { | ||
| codec: T, | ||
| pub struct TripleServer<T, V> { | ||
| _pd: PhantomData<(T, V)>, |
There was a problem hiding this comment.
将TripleServer中 T, V 这两个泛型 改成 M1, M2，和TripleClient保持一致。注意区分哪个是request和response
dubbo/src/triple/client/triple.rs
Outdated
| { | ||
| let config = | ||
| ConsumerConfig::get_global_consumer_config(invocation.get_target_service_unique_name()); |
There was a problem hiding this comment.
这种实现方式有些不太好：配置逻辑侵入到核心代码中，并且这是一段隐藏逻辑。
根据service_name来动态地从配置文件中获取codec、compress 这个功能可以先去掉。这个功能应该在一个单独的feature里来做。
我建议：这个pr可以先支持基于ClientBuilder的静态配置的方式。将codec和compress配置项加在ClientBuilder里。另外，可以通过加载配置文件来初始化ClientBuilder，进而初始化TripleClient。
dubbo-build/src/server.rs
Outdated
| @@ -330,7 +328,7 @@ fn generate_unary<T: Method>( | |||
| method_ident: Ident, | |||
| server_trait: Ident, | |||
| ) -> TokenStream { | |||
| let codec_name = syn::parse_str::<syn::Path>(CODEC_PATH).unwrap(); | |||
| // let codec_name = syn::parse_str::<syn::Path>(CODEC_PATH).unwrap(); | |||
… loading method.(#145)
The RPC client now exclusively uses protobuf for serialization.
|
Good work. Thanks for your contribution to dubbo-rust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented support for grpc+Json, and enabled direct communication between curl tool and unary services