fix ExecutorRepositoryTest test failures

apache · Jan 28, 2021 · 5c7cf64 · 5c7cf64
1 parent 6375c1b
commit 5c7cf64
Showing 1 changed file with 20 additions and 3 deletions.
diff --git a/...mmon/src/test/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepositoryTest.java b/...mmon/src/test/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepositoryTest.java
@@ -30,15 +30,32 @@ public class ExecutorRepositoryTest {
 
  @Test
  public void testGetExecutor() {
- testGet(URL.valueOf("dubbo://127.0.0.1:23456"));
- testGet(URL.valueOf("dubbo://127.0.0.1:23456?side=consumer"));
+ testGet(URL.valueOf("dubbo://127.0.0.1:23456"), true);
+ testGet(URL.valueOf("dubbo://127.0.0.1:23456?side=consumer"), false);
 
  Assertions.assertNotNull(executorRepository.getSharedExecutor());
  Assertions.assertNotNull(executorRepository.getServiceExporterExecutor());
  executorRepository.nextScheduledExecutor();
  }
 
- private void testGet(URL url) {
+ private void testGet(URL url, Boolean isFirst) {
+ if (isFirst) {
+ Assertions.assertNull(executorRepository.getExecutor(url));
+ } else {
+ Assertions.assertEquals(executorRepository.getExecutor(url), executorRepository.getSharedExecutor());
+ }
+
+ ExecutorService executorService = executorRepository.createExecutorIfAbsent(url);
+ executorService.shutdown();
+ executorService = executorRepository.createExecutorIfAbsent(url);
+ Assertions.assertFalse(executorService.isShutdown());
+
+ Assertions.assertEquals(executorService, executorRepository.getExecutor(url));
+ executorService.shutdown();
+ Assertions.assertNotEquals(executorService, executorRepository.getExecutor(url));
+ }
+
+ private void testGetNotShared(URL url) {
  Assertions.assertNull(executorRepository.getExecutor(url));
 
  ExecutorService executorService = executorRepository.createExecutorIfAbsent(url);