fix

apache · Jan 31, 2023 · 6616818 · 6616818
1 parent 5f5959b
commit 6616818
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...etrics-default/src/main/java/org/apache/dubbo/metrics/report/AbstractMetricsReporter.java b/...etrics-default/src/main/java/org/apache/dubbo/metrics/report/AbstractMetricsReporter.java
@@ -113,6 +113,10 @@ private void addJvmMetrics() {
                 Optional.ofNullable(applicationModel.getApplicationName()).orElse(""));
             new ClassLoaderMetrics(extraTags).bindTo(compositeRegistry);
             new JvmMemoryMetrics(extraTags).bindTo(compositeRegistry);
+
+            @SuppressWarnings("java:S2095")
+            // Do not change JvmGcMetrics to try-with-resources as the JvmGcMetrics will not be available after (auto-)closing.
+            // See https://github.com/micrometer-metrics/micrometer/issues/1492
             JvmGcMetrics jvmGcMetrics = new JvmGcMetrics(extraTags);
             jvmGcMetrics.bindTo(compositeRegistry);
             Runtime.getRuntime().addShutdownHook(new Thread(jvmGcMetrics::close));