Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update FileTest in 3.3 #13961

Closed
3 of 4 tasks
AlbumenJ opened this issue Mar 20, 2024 · 5 comments
Closed
3 of 4 tasks

[Feature] Update FileTest in 3.3 #13961

AlbumenJ opened this issue Mar 20, 2024 · 5 comments
Assignees
Labels
component/sdk Related with apache/dubbo good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance

Comments

@AlbumenJ
Copy link
Member

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Update org.apache.dubbo.dependency.FileTest in 3.3 to support check dubbo-all-shaded and dubbo-core-spi

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@AlbumenJ AlbumenJ added help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance good first issue Good for starters to contribute component/sdk Related with apache/dubbo labels Mar 20, 2024
@Stellar1999
Copy link
Contributor

Stellar1999 commented Mar 21, 2024

I would like to try to do this. Can you assign it to me? Thanks~
I think I should remove them from the ignored list and add them to the dependencies pom, which will check them.

Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Mar 21, 2024
Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Mar 22, 2024
@Stellar1999 Stellar1999 mentioned this issue Mar 22, 2024
8 tasks
@CrazyHZM
Copy link
Member

@AlbumenJ This can describe the content of the specific need to check what it is.
This PR (#13978) does not understand what needs to be done.

@Stellar1999
Copy link
Contributor

I would like to try to do this. Can you assign it to me? Thanks~ I think I should remove them from the ignored list and add them to the dependencies pom, which will check them.

@AlbumenJ This can describe the content of the specific need to check what it is. This PR (#13978) does not understand what needs to be done.

Sorry for that. I think I actually didn't understand. As I said, I think dubbo-all-shaded and dubbo-core-spi are new modules that need to be checked. Now, when @CrazyHZM reninded it, I think they should have their own checks like dubbo-all and dubbo-bom. This time, do I understand correctly?

@Stellar1999
Copy link
Contributor

Another question, what is the positioning of core-spi and all-shaded? Are they gradually replacing the SPI and includes in dubbo-all using the Maven Shade Plugin? I think dubbo-all-shaded should imply this, but dubbo-core-spi hasn't been updated for a long time. I'm not sure whether it should only check the included SPI or all SPI. Should I also update the SPI dependencies in pom?

@AlbumenJ
Copy link
Member Author

Update checkDubboAllTransform in FileTest to check dubbo-all-shaded and dubbo-core-spi

Stellar1999 added a commit to Stellar1999/dubbo that referenced this issue Mar 26, 2024
AlbumenJ pushed a commit that referenced this issue Mar 29, 2024
@CrazyHZM CrazyHZM closed this as completed Apr 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Dubbo Board Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sdk Related with apache/dubbo good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance
Projects
Archived in project
Development

No branches or pull requests

3 participants