-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApplicationModel serviceName is not unique #2583
Comments
It is dependent on how do you defind a Service:
|
Yes. |
@haiyang1985 I drop a comment in #2582 (review), pls. take a look. |
* update README * #2583: ApplicationModel serviceName is not unique
I don't think this is a problem or fixing bug. Here are two reasions.
For example, a group rule or route rule is defined in ZK, which service is it applied to? I think, serviceKey (name, group, version) is the condition. So as the online/offline rules. |
@Jeff-Lv I agree with your opinion. For this particular problem, let's consider it as a limitation. User cannot configure two references with the different behavior. We will provide alternative way to user to change the behavior either via API, utilities or dynamic config. Let's roll back the relevant change in #2646. |
Environment
Steps to reproduce this issue
<dubbo:reference id="demoService" interface="com.alibaba.dubbo.DemoService">
</dubbo:reference>
<dubbo:reference id="demoServiceAsync" interface="com.alibaba.dubbo.DemoService" async="true">
</dubbo:reference>
Pls. provide [GitHub address] to reproduce this issue.
Expected Result
ApplicationModel.allConsumerModels() should returns two ConsumerModel.
Actual Result
ApplicationModel.allConsumerModels() only returns the first ConsumerModel.
If there is an exception, please attach the exception trace:
With future investigation, ReferenceConfig cannot put the second ConsumerModel as they are in same serviceName.
Also, this is the same issue for provider with below configuration.
<dubbo:service interface="com.alibaba.dubbo.DemoService" ref="demoService">
</dubbo:service>
<dubbo:service interface="com.alibaba.dubbo.DemoService" ref="demoService2">
</dubbo:service>
Here is my PR: #2582
The text was updated successfully, but these errors were encountered: