Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup of #10010, share proxy instance among References that have the same key. #10017

Merged
merged 2 commits into from
May 10, 2022

Conversation

chickenlj
Copy link
Contributor

related to #10012

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #10017 (96b959c) into 3.0 (ec98ff3) will decrease coverage by 0.02%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##                3.0   #10017      +/-   ##
============================================
- Coverage     65.75%   65.72%   -0.03%     
+ Complexity      320      319       -1     
============================================
  Files          1218     1218              
  Lines         53052    53061       +9     
  Branches       8037     8040       +3     
============================================
- Hits          34883    34874       -9     
- Misses        14368    14379      +11     
- Partials       3801     3808       +7     
Impacted Files Coverage Δ
...g/apache/dubbo/config/AbstractInterfaceConfig.java 79.74% <33.33%> (-0.45%) ⬇️
...pache/dubbo/config/utils/SimpleReferenceCache.java 69.47% <66.66%> (+0.93%) ⬆️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 75.92% <0.00%> (-3.71%) ⬇️
.../dubbo/registry/client/metadata/MetadataUtils.java 61.90% <0.00%> (-3.58%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../apache/dubbo/remoting/transport/CodecSupport.java 80.30% <0.00%> (-3.04%) ⬇️
...bbo/common/resource/GlobalResourcesRepository.java 72.72% <0.00%> (-1.82%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 67.71% <0.00%> (-1.80%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec98ff3...96b959c. Read the comment docs.

@chickenlj chickenlj requested a review from AlbumenJ May 10, 2022 01:40
@chickenlj chickenlj merged commit d0ae161 into apache:3.0 May 10, 2022
@chickenlj
Copy link
Contributor Author

Reviewed by Albumen

@chickenlj chickenlj deleted the reference-cache-10010-2 branch May 10, 2022 01:43
@AlbumenJ AlbumenJ added this to the 3.0.9 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants