Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs reported in dubbo-admin #1026

Merged
merged 3 commits into from
Dec 11, 2017
Merged

Fix some bugs reported in dubbo-admin #1026

merged 3 commits into from
Dec 11, 2017

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

Fix some bugs find in dubbo-admin

Brief changelog

  1. Fixed 2.5.4 系统管理的二级标签打不开,相对路径不正确 #466, use relative path when redirect
  2. Fixed The promotion for 'batch recover of fault tolerant' functionality in dubbo-admin is incorrect. #972, promotion error of 'batch recover' on 'application' tab
  3. Fix dubbo-admin, cache refresh problem when service changed

Verifying this change

Mostly web redirect change, verify by deploy dubbo-admin and visit on browser.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@chickenlj chickenlj merged commit 1f2dcbe into apache:master Dec 11, 2017
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
* Fix dubbo-admin, cache refresh problem when service changed
* Fixed apache#972, promotion error of 'batch recover' on 'application' tab
* Fixed apache#466, use relative path when redirect
@dangle253280 dangle253280 mentioned this pull request Feb 23, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant