-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tracing starters && add zipkin auto configuration #12013
Conversation
dubbo-common/src/main/java/org/apache/dubbo/config/nested/ExporterConfig.java
Outdated
Show resolved
Hide resolved
@songxiaosheng PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduce a new starter like dubbo-spring-boot-zipkin-starter would be better
@songxiaosheng PTAL |
Codecov Report
@@ Coverage Diff @@
## 3.2 #12013 +/- ##
============================================
- Coverage 70.02% 69.44% -0.58%
+ Complexity 339 2 -337
============================================
Files 1802 1589 -213
Lines 93710 65330 -28380
Branches 17012 9513 -7499
============================================
- Hits 65620 45370 -20250
+ Misses 22775 15592 -7183
+ Partials 5315 4368 -947 see 3391 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
tracing example config:
Add two types of observ starters:
samples
Brief changelog
Verifying this change
Checklist