Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing starters && add zipkin auto configuration #12013

Merged
merged 15 commits into from
Apr 15, 2023

Conversation

conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Apr 4, 2023

What is the purpose of the change

tracing example config:

  tracing:
    enabled: true # default is false
    sampling:
      probability: 0.5 # sampling rate, default is 0.1
    propagation:
      type: W3C # W3C/B3 default is W3C
    tracing-exporter:
      zipkin-config:
        endpoint: http://localhost:9411/api/v2/spans
        connect-timeout: 1s # connect timeout, default is 1s
        read-timeout: 10s # read timeout, default is 10s

Add two types of observ starters:

  • dubbo-spring-boot-tracing-otel-zipkin-starter
  • dubbo-spring-boot-tracing-brave-zipkin-starter

image

samples

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu conghuhu requested a review from AlbumenJ April 4, 2023 10:44
@conghuhu
Copy link
Contributor Author

conghuhu commented Apr 4, 2023

@songxiaosheng PTAL

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce a new starter like dubbo-spring-boot-zipkin-starter would be better

@conghuhu conghuhu requested a review from AlbumenJ April 12, 2023 02:42
@conghuhu conghuhu changed the title faet: add zipkin auto configuration feat: add zipkin auto configuration Apr 12, 2023
@conghuhu
Copy link
Contributor Author

@songxiaosheng PTAL

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #12013 (d4d9358) into 3.2 (736d996) will decrease coverage by 0.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12013      +/-   ##
============================================
- Coverage     70.02%   69.44%   -0.58%     
+ Complexity      339        2     -337     
============================================
  Files          1802     1589     -213     
  Lines         93710    65330   -28380     
  Branches      17012     9513    -7499     
============================================
- Hits          65620    45370   -20250     
+ Misses        22775    15592    -7183     
+ Partials       5315     4368     -947     

see 3391 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conghuhu conghuhu changed the title feat: add zipkin auto configuration feat: add tracing starters && add zipkin auto configuration Apr 13, 2023
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

1.1% 1.1% Coverage
0.0% 0.0% Duplication

@songxiaosheng songxiaosheng merged commit 559b13a into apache:3.2 Apr 15, 2023
@conghuhu conghuhu deleted the cgq branch April 15, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants