Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics bug fix #12088

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Metrics bug fix #12088

merged 1 commit into from
Apr 14, 2023

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Apr 13, 2023

What is the purpose of the change

Error statistics do not match

image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12088 (654fc43) into 3.2 (ff4c1e8) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12088      +/-   ##
============================================
- Coverage     69.95%   69.68%   -0.28%     
+ Complexity      319        2     -317     
============================================
  Files          3385     1583    -1802     
  Lines        159025    65251   -93774     
  Branches      26380     9501   -16879     
============================================
- Hits         111253    45471   -65782     
+ Misses        38121    15422   -22699     
+ Partials       9651     4358    -5293     

see 1832 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit 302f57c into apache:3.2 Apr 14, 2023
@wxbty wxbty deleted the request_metrics_bug branch April 14, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants