Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12233 redis cluster not support password bug. #12240

Merged
merged 2 commits into from
May 7, 2023
Merged

fix #12233 redis cluster not support password bug. #12240

merged 2 commits into from
May 7, 2023

Conversation

goto456
Copy link
Contributor

@goto456 goto456 commented May 6, 2023

What is the purpose of the change

fix the bug of not support redis cluster password

Brief changelog

init the value of password before use it, when redis model is cluster.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Merging #12240 (7da3ffa) into 3.2 (c5f8ce6) will increase coverage by 0.74%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12240      +/-   ##
============================================
+ Coverage     68.81%   69.55%   +0.74%     
+ Complexity      115        2     -113     
============================================
  Files          3559     1603    -1956     
  Lines        163607    65806   -97801     
  Branches      26766     9598   -17168     
============================================
- Hits         112581    45770   -66811     
+ Misses        41226    15640   -25586     
+ Partials       9800     4396    -5404     

see 1988 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@goto456 goto456 closed this May 6, 2023
@goto456 goto456 reopened this May 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants