support passing detect context to help build netty handlers #12460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyHZM
requested changes
Jun 6, 2023
| @@ -36,6 +37,8 @@ public class NettyConfigOperator implements ChannelOperator { | |||
| private final Channel channel; | |||
| private ChannelHandler handler; | |||
|
|
|||
| private ProtocolDetector.Result detectResult; | |||
There was a problem hiding this comment.
Where will this be used? I don't seem to see a place to use it?
There was a problem hiding this comment.
This is for the triple protocol to support both http1 and http2
|
Kudos, SonarCloud Quality Gate passed! |
CrazyHZM
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support passing detect context to help build netty handlers.
Supports multiple versions of the same protocol, for example: HTTP -> HTTP1, HTTP2, HTTP3
Brief changelog