-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi registries metrics key #12582
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.2 #12582 +/- ##
============================================
+ Coverage 69.40% 69.42% +0.02%
Complexity 2 2
============================================
Files 1644 1646 +2
Lines 68196 68296 +100
Branches 9973 9976 +3
============================================
+ Hits 47329 47413 +84
- Misses 16288 16300 +12
- Partials 4579 4583 +4 see 60 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@songxiaosheng PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Outdated
Show resolved
Hide resolved
...fig/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RegistryDirectory
should also be categoried with REGISTRY_CLUSTER
too
...pi/src/main/java/org/apache/dubbo/registry/client/metadata/ServiceInstanceMetadataUtils.java
Outdated
Show resolved
Hide resolved
...fig/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
Issue Number: close #12531
app-level
service-level