Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi registries metrics key #12582

Merged
merged 58 commits into from
Jul 31, 2023
Merged

Support multi registries metrics key #12582

merged 58 commits into from
Jul 31, 2023

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Jun 21, 2023

What is the purpose of the change

Issue Number: close #12531

app-level
image

service-level
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #12582 (a7c739d) into 3.2 (1087070) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12582      +/-   ##
============================================
+ Coverage     69.40%   69.42%   +0.02%     
  Complexity        2        2              
============================================
  Files          1644     1646       +2     
  Lines         68196    68296     +100     
  Branches       9973     9976       +3     
============================================
+ Hits          47329    47413      +84     
- Misses        16288    16300      +12     
- Partials       4579     4583       +4     

see 60 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ requested a review from songxiaosheng June 24, 2023 09:02
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxbty wxbty requested a review from AlbumenJ June 28, 2023 12:53
@AlbumenJ
Copy link
Member

image

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RegistryDirectory should also be categoried with REGISTRY_CLUSTER too

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

45.0% 45.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 0add70e into apache:3.2 Jul 31, 2023
@wxbty wxbty deleted the registry_multi branch January 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple registries metrics overlap each other
4 participants