fix the consumer remoteApplication is null #12635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #12631 |
xixingya
force-pushed
the
feature/230630-fix
branch
from
47f95f1 to
ac7d7d9
Compare
AlbumenJ
requested changes
Jul 1, 2023
Comment on lines
203
to
208
| public void setUrl(URL url) { | ||
| this.url = url; | ||
| if (url.getSide().equals(CommonConstants.CONSUMER)) { | ||
| this.remoteApplicationName = url.getRemoteApplication(); | ||
| this.setRemoteAddress(url.getHost(), url.getPort()); | ||
| } |
There was a problem hiding this comment.
Set remote attribute in org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker#invokeWithContext would be a better choice.
private static void setRemote(Invoker<?> invoker, Invocation invocation) {
invocation.addInvokedInvoker(invoker);
RpcContext.getServiceContext().setRemoteAddress(invoker.getUrl().toInetSocketAddress());
RpcContext.getServiceContext().setRemoteApplicationName(invoker.getUrl().getRemoteApplication());
}
There was a problem hiding this comment.
@AlbumenJ hello, I have fix them,and I run the local test on filter can get them
AlbumenJ
requested changes
Jul 1, 2023
| @@ -107,8 +107,6 @@ protected Result doInvoke(final Invocation invocation) throws Throwable { | |||
|
|
|||
| invocation.setAttachment(TIMEOUT_KEY, String.valueOf(timeout)); | |||
|
|
|||
| RpcContext.getServiceContext().setRemoteAddress(currentClient.getRemoteAddress()); | |||
xixingya
force-pushed
the
feature/230630-fix
branch
from
14dc66f to
3a0c31f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Jul 2, 2023
|
LGTM. Thx your contributions~ |
|
@AlbumenJ hello, did dubbo have a ding talk group,I have send a email to you,the qr code on the https://cn.dubbo.apache.org/zh-cn/contact/ is invalid |
You can add my dingtak directly. |
|
@AlbumenJ 3.1.8也遇到此问题，3.1.x是否有修复计划？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#12631
Brief changelog
Verifying this change
Checklist
fix the consumer remoteApplicationName is null