RequestEvent optimization

[CLFutureX]

What is the purpose of the change

issue

Brief changelog

Verifying this change

Checklist

• Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
• Add some description to dubbo-website project if you are requesting to add a feature.
• GitHub Actions works fine on your own branch.
• If this contribution is large, please follow the Software Donation Guide.

[codecov-commenter]

Codecov Report

Merging #12655 (e9ee030) into 3.2 (49886b7) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12655      +/-   ##
============================================
+ Coverage     69.36%   69.39%   +0.03%     
  Complexity        2        2              
============================================
  Files          1647     1646       -1     
  Lines         68198    68198              
  Branches       9966     9967       +1     
============================================
+ Hits          47304    47327      +23     
+ Misses        16325    16307      -18     
+ Partials       4569     4564       -5     

see 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[songxiaosheng]

LGTM

[AlbumenJ]

Please resolve conflicts

[CLFutureX]

Please resolve conflicts

Well, it's resolved

[AlbumenJ]

It would be better to rename requestBeforeEvent to requestErrorEvent

[CLFutureX]

It would be better to rename requestBeforeEvent to requestErrorEvent

I don't think so because this is applied to MetricsClusterFilter to monitor exceptions that occur before executing requests

[CLFutureX]

It would be better to rename requestBeforeEvent to requestErrorEvent

It would be better to rename requestBeforeEvent to requestErrorEvent

The focus of this event is that the request was aborted before execution,
so I think requestBeforeEvent is more appropriate. Do you think so

[AlbumenJ]

It would be better to rename requestBeforeEvent to requestErrorEvent

It would be better to rename requestBeforeEvent to requestErrorEvent

The focus of this event is that the request was aborted before execution, so I think requestBeforeEvent is more appropriate. Do you think so

However there are only one event in the case

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

85.7% Coverage
0.0% Duplication

[CLFutureX]

It would be better to rename requestBeforeEvent to requestErrorEvent

It would be better to rename requestBeforeEvent to requestErrorEvent

The focus of this event is that the request was aborted before execution, so I think requestBeforeEvent is more appropriate. Do you think so

However there are only one event in the case

Oh, sure! I've made the update

[AlbumenJ]

@songxiaosheng PTAL