Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip warn if provider app and consumer app are the same #12729

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Fix #12540

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
50.0% 50.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12729 (269d172) into 3.2 (49886b7) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12729      +/-   ##
============================================
+ Coverage     69.36%   69.42%   +0.05%     
  Complexity        2        2              
============================================
  Files          1647     1647              
  Lines         68198    68200       +2     
  Branches       9966     9967       +1     
============================================
+ Hits          47304    47346      +42     
+ Misses        16325    16292      -33     
+ Partials       4569     4562       -7     

see 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ requested a review from chickenlj July 15, 2023 02:09
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit ff60c87 into apache:3.2 Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants