Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify non-standard naming #13059

Merged
merged 3 commits into from
Sep 25, 2023
Merged

refactor: modify non-standard naming #13059

merged 3 commits into from
Sep 25, 2023

Conversation

liuzg-coder
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@liuzg-coder
Copy link
Contributor Author

modify non-standard naming

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.2% 72.2% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (9eb49e2) to head (b2d0448).
Report is 904 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #13059      +/-   ##
============================================
- Coverage     68.24%   68.21%   -0.03%     
  Complexity        6        6              
============================================
  Files          1717     1717              
  Lines         70844    70844              
  Branches      10256    10256              
============================================
- Hits          48345    48329      -16     
- Misses        17813    17827      +14     
- Partials       4686     4688       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 0fd51b1 into apache:3.3 Sep 25, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants