Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For HTTP/1 unary mode, use Content-Length instead of chunk #13979

Merged

Conversation

finefuture
Copy link
Contributor

@finefuture finefuture commented Mar 22, 2024

What is the purpose of the change

Refer: #13933

For example:
image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@finefuture
Copy link
Contributor Author

@oxsean PTAL

TomlongTK and others added 2 commits March 25, 2024 15:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.54%. Comparing base (a12975a) to head (050d2d0).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13979      +/-   ##
==========================================
- Coverage   38.55%   38.54%   -0.01%     
==========================================
  Files        1895     1896       +1     
  Lines       79272    79302      +30     
  Branches    11528    11527       -1     
==========================================
+ Hits        30560    30565       +5     
- Misses      44439    44466      +27     
+ Partials     4273     4271       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For HTTP/2 unary, should we fix it?

@finefuture
Copy link
Contributor Author

For HTTP/2 unary, should we fix it?

Maybe we don't need to fix it, refer to this link: https://stackoverflow.com/questions/77520309/why-is-content-length-header-not-sent-over-http-3.
@oxsean What do you think?

@oxsean
Copy link
Collaborator

oxsean commented Mar 26, 2024

@AlbumenJ @finefuture I think END_STREAM flag is enough, because END_STREAM flag is mandatory.

@AlbumenJ
Copy link
Member

@oxsean PTAL

@oxsean
Copy link
Collaborator

oxsean commented Apr 2, 2024

@AlbumenJ LGTM

Copy link

sonarqubecloud bot commented Apr 2, 2024

@AlbumenJ AlbumenJ merged commit 0840c60 into apache:3.3 Apr 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants