Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonar issue s2293 The diamond operator ('<>') should be used #14005

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Fix Sonar issue s2293 The diamond operator ('<>') should be used #14005

merged 11 commits into from
Mar 29, 2024

Conversation

jlerbsc
Copy link
Contributor

@jlerbsc jlerbsc commented Mar 27, 2024

We propose the fix to violation s2293 "The diamond operator ('<>') should be used" identified by SonarQube.

Java uses angular brackets (< and >) to provide a specific type (the "type argument") to a generic type. For instance, List is a generic type, so a list containing strings can be declared with List.
Prior to Java 7, the type argument had to be provided explicitly for every occurrence where generics were used. This often caused redundancy, as the type argument would have to be provided both when a field is declared and initialized.
Java 7 introduced the diamond operator (<>) to reduce the code’s verbosity of generics code. The type argument between the angular brackets should be omitted if the compiler can infer it. For instance, instead of having to declare a List's type in both its declaration and its constructor, you can now simplify the constructor declaration with <>, and the compiler will infer the type.

This patch has been automatically produced by our java code remediation solution, available free of charge for all open source projects (https://www.indepth.fr/).

We believe that this PR can improve the quality of the Guava project code to a certain extent. Your feedback will also be very useful for us to know if our solution produces quality code or if we need to improve the way it works.

Thank you for your feedback.

Copy link

sonarcloud bot commented Mar 28, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.41%. Comparing base (4be3587) to head (f70109a).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #14005      +/-   ##
==========================================
- Coverage   70.42%   70.41%   -0.01%     
==========================================
  Files        1607     1607              
  Lines       70075    70074       -1     
  Branches    10100    10100              
==========================================
- Hits        49348    49342       -6     
  Misses      16087    16087              
- Partials     4640     4645       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 00812ce into apache:3.2 Mar 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants