Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3.2): ReactorDubbo3TripleStub.mustache add schema registry #14035

Merged
merged 2 commits into from
May 8, 2024

Conversation

caoyanan666
Copy link
Contributor

What is the purpose of the change

The ReactorDubbo3TripleStub.mustache template does not add schema registration. In this case, the gateway cannot pull all interface information and cannot make generalized calls. It should be consistent with Dubbo3TripleStub.mustache and add schema registration.
image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@caoyanan666
Copy link
Contributor Author

@AlbumenJ
image
Is the dubbo-samples-triple-reactor module not in the project? How should I fix this unit test?

@AlbumenJ
Copy link
Member

AlbumenJ commented Apr 8, 2024

@AlbumenJ image Is the dubbo-samples-triple-reactor module not in the project? How should I fix this unit test?

https://github.com/apache/dubbo-samples/tree/master/3-extensions/protocol/dubbo-samples-triple-reactor

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@caoyanan666
Copy link
Contributor Author

@AlbumenJ PTAL

@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

@EarthChen PTAL

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 7f6deca into apache:3.2 May 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants