Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bytebuf resource leak #14071

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Apr 12, 2024

What is the purpose of the change

fix #14070

Netty will automatically release the reference-counted object when calling the channel.flush() method usually. The org.apache.dubbo.rpc.protocol.tri.stream.TripleServerStream.ServerTransportObserver#doOnData released the Bytebuf on deframer.deframe(data);, but while it return directlly the reference-counted will not be release.

Brief changelog

fix TripleServerStream resource leak

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@icodening icodening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icodening icodening merged commit ca7151e into apache:3.2 Apr 16, 2024
19 checks passed
Chenjp added a commit to Chenjp/dubbo that referenced this pull request Apr 16, 2024
fix: Bytebuf resource leak (apache#14071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Memory leak in TripleServerStream.ServerTransportObserver#doOnData
3 participants