New metadata service #14210
Merged
New metadata service #14210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 3.3-new-metadata-service-stub
|
Well done. Generally looks good to me. |
…nto 3.3-new-metadata-service-stub
…nto 3.3-new-metadata-service-stub
FoghostCn
reviewed
Jun 8, 2024
chickenlj
reviewed
Jun 18, 2024
| @@ -96,6 +96,8 @@ public class ServiceInstanceMetadataUtils { | |||
| */ | |||
| public static final String METADATA_STORAGE_TYPE_PROPERTY_NAME = "dubbo.metadata.storage-type"; | |||
|
|
|||
| public static final String METADATA_SERVICE_VERSION_NAME = "dubbo.metadata.service-version"; | |||
There was a problem hiding this comment.
Use as short a name as possible, for example, meta-v.
AlbumenJ
requested changes
Jun 23, 2024
dubbo-metadata/dubbo-metadata-api/src/main/proto/metadata_service_v2.proto
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the Change
This PR introduces a new version of
MetadataService(V2) based on Protobuf, which provides better compatibility with dubbo-go.See #13584
Brief Changelog
To use
MetadataServiceV2, the application must meet the following requirements:metadataServiceProtocolis configured as 'tri', or at least one service is using the triple protocol.Currently,
MetadataServiceV2will automatically export along withMetadataService(V1, on the same port) if the above requirements are satisfied. IfonlyUseMetadataV2is set totrue, onlyMetadataServiceV2will be exported. If the above requirements are not satisfied, Dubbo will still only exportMetadataService(V1).