Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not initialize MetricsReporter if not support prometheus #14225

Merged
merged 2 commits into from
May 22, 2024
Merged

fix: not initialize MetricsReporter if not support prometheus #14225

merged 2 commits into from
May 22, 2024

Conversation

qyi71
Copy link
Contributor

@qyi71 qyi71 commented May 21, 2024

What is the purpose of the change

if set config set
dubbo: metrics: enable: false enable-collector-sync: false enable-jvm: false enable-metadata: false enable-metrics-init: false enable-threadpool: false enable-registry: false enable-rpc: false export-metrics-service: false protocol: prometheus port: 9090
and import dubbo-spring-boot-starter of version 3.2.6

it will print wran "java.lang.NoClassDefFoundError: io/prometheus/client/exporter/HttpConnectionFactory"

Brief changelog

Verifying this change

org.apache.dubbo.config.deploy.DefaultApplicationDeployerTest#isImportPrometheus

Checklist

  • [] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FoghostCn FoghostCn requested review from songxiaosheng and wxbty May 21, 2024 12:30
@AlbumenJ AlbumenJ merged commit b12b23c into apache:3.2 May 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants